Feat: Better Handling of FrameButton post actions #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zizzamia
reviewed
Aug 15, 2024
| @@ -95,6 +95,7 @@ export type FrameButtonMetadata = | |||
| | { | |||
| action?: 'post' | 'post_redirect'; | |||
| label: string; | |||
| postUrl?: string; | |||
There was a problem hiding this comment.
Is this part of the Frame Spec? And where is this writtend?
There was a problem hiding this comment.
Per Button Actions, we are told that a post should send an HTTP request to the button's post_url.
But as currently configured, getFrameMetadata does not set a fc:frame:button:[id]:post_url property for post actions, only tx actions:
if (buttons) {
buttons.forEach((button, index) => {
metadata[`fc:frame:button:${index + 1}`] = button.label;
if (button.action) {
metadata[`fc:frame:button:${index + 1}:action`] = button.action;
}
if (button.target) {
metadata[`fc:frame:button:${index + 1}:target`] = button.target;
}
if (button.action && button.action === 'tx' && button.postUrl) {
metadata[`fc:frame:button:${index + 1}:post_url`] = button.postUrl;
}
});
}
The above change to FrameButtonMetadata is required for strict type-checking of the getFrameMetadata logic.
|
@brendan-defi is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Zizzamia
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
FrameButtonMetadatato allow custompostUrlpropertygetFrameMetadatato handle custompostUrls on Frame ButtonsNotes to reviewers
How has it been tested?